Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4713bd1c authored by Joe Perches's avatar Joe Perches Committed by Kalle Valo
Browse files

rtlwifi: Add missing newlines to RT_TRACE calls 



RT_TRACE does not add a newline to the end of a message and always
emits at KERN_DEBUG so these are susceptible to message interleaving
from other processes without the newline.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 9ce22191

drivers/net/wireless/realtek/rtlwifi/core.c

+1 −1
Original line number Diff line number Diff line
@@ -526,7 +526,7 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw, 
		/* 3. calculate crc */

		rtl_pattern.crc = _calculate_wol_pattern_crc(content, len);

		RT_TRACE(rtlpriv, COMP_POWER, DBG_TRACE,

			 "CRC_Remainder = 0x%x", rtl_pattern.crc);

			 "CRC_Remainder = 0x%x\n", rtl_pattern.crc);



		/* 4. write crc & mask_for_hw to hw */

		rtlpriv->cfg->ops->add_wowlan_pattern(hw, &rtl_pattern, i);

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c

+2 −2
Original line number Diff line number Diff line
@@ -1846,12 +1846,12 @@ static void _rtl88ee_read_adapter_info(struct ieee80211_hw *hw) 


	case EEPROM_93C46:

		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,

			 "RTL819X Not boot from eeprom, check it !!");

			 "RTL819X Not boot from eeprom, check it !!\n");

		return;



	default:

		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,

			 "boot from neither eeprom nor efuse, check it !!");

			 "boot from neither eeprom nor efuse, check it !!\n");

		return;

	}

	memcpy(hwinfo, &rtlefuse->efuse_map[EFUSE_INIT_MAP][0], HWSET_MAX_SIZE);

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c

+2 −2
Original line number Diff line number Diff line
@@ -373,7 +373,7 @@ static bool _rtl88e_phy_bb8188e_config_parafile(struct ieee80211_hw *hw) 


	rtstatus = phy_config_bb_with_headerfile(hw, BASEBAND_CONFIG_PHY_REG);

	if (!rtstatus) {

		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, "Write BB Reg Fail!!");

		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, "Write BB Reg Fail!!\n");

		return false;

	}
@@ -383,7 +383,7 @@ static bool _rtl88e_phy_bb8188e_config_parafile(struct ieee80211_hw *hw) 
		  phy_config_bb_with_pghdr(hw, BASEBAND_CONFIG_PHY_REG);

	}

	if (!rtstatus) {

		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, "BB_PG Reg Fail!!");

		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, "BB_PG Reg Fail!!\n");

		return false;

	}

	rtstatus =

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c

+1 −1
Original line number Diff line number Diff line
@@ -498,7 +498,7 @@ static bool _rtl88e_phy_rf6052_config_parafile(struct ieee80211_hw *hw) 


		if (rtstatus != true) {

			RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,

				 "Radio[%d] Fail!!", rfpath);

				 "Radio[%d] Fail!!\n", rfpath);

			return false;

		}

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c

+2 −2
Original line number Diff line number Diff line
@@ -540,7 +540,7 @@ void rtl88ee_tx_fill_desc(struct ieee80211_hw *hw, 
				 PCI_DMA_TODEVICE);

	if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {

		RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,

			 "DMA mapping error");

			 "DMA mapping error\n");

		return;

	}

	CLEAR_PCI_TX_DESC_CONTENT(pdesc, sizeof(struct tx_desc_88e));
@@ -703,7 +703,7 @@ void rtl88ee_tx_fill_cmddesc(struct ieee80211_hw *hw, 


	if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {

		RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,

			 "DMA mapping error");

			 "DMA mapping error\n");

		return;

	}

	CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE);