Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 46f1c52e authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

nfp: TX time stamp packets before HW doorbell is rung 



TX completion may happen any time after HW queue was kicked.
We can't access the skb afterwards.  Move the time stamping
before ringing the doorbell.

Fixes: 4c352362 ("net: add driver for Netronome NFP4000/NFP6000 NIC VFs")
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: default avatarSimon Horman <simon.horman@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ee6c88bb

drivers/net/ethernet/netronome/nfp/nfp_net_common.c

+2 −2
Original line number Diff line number Diff line
@@ -895,6 +895,8 @@ static int nfp_net_tx(struct sk_buff *skb, struct net_device *netdev) 


	netdev_tx_sent_queue(nd_q, txbuf->real_len);



	skb_tx_timestamp(skb);



	tx_ring->wr_p += nr_frags + 1;

	if (nfp_net_tx_ring_should_stop(tx_ring))

		nfp_net_tx_ring_stop(nd_q, tx_ring);
@@ -903,8 +905,6 @@ static int nfp_net_tx(struct sk_buff *skb, struct net_device *netdev) 
	if (!skb->xmit_more || netif_xmit_stopped(nd_q))

		nfp_net_tx_xmit_more_flush(tx_ring);



	skb_tx_timestamp(skb);



	return NETDEV_TX_OK;



err_unmap: