Commit 46de8ff8 authored Jul 28, 2014 by Michael Welling Committed by Lee Jones Jul 29, 2014

mfd: omap-usb-host: Fix improper mask use.



single-ulpi-bypass is a flag used for older OMAP3 silicon.

The flag when set, can excite code that improperly uses the
OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit.
Instead it clears all of the other bits disabling all of the ports in
the process.

Cc: stable@vger.kernel.org
Signed-off-by: Michael Welling <mwelling@emacinc.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 30a2af3a

drivers/mfd/omap-usb-host.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -445,7 +445,7 @@ static unsigned omap_usbhs_rev1_hostconfig(struct usbhs_hcd_omap *omap,

		for (i = 0; i < omap->nports; i++) {
		if (is_ehci_phy_mode(pdata->port_mode[i])) {
		reg &= OMAP_UHH_HOSTCONFIG_ULPI_BYPASS;
		reg &= ~OMAP_UHH_HOSTCONFIG_ULPI_BYPASS;
		break;
		}
		}