Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4676ba0b authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm: Check locking in drm_for_each_fb 



Ever since framebuffers are reference counted we have a special lock
for the global fb list. Make sure users of that list do hold that
lock when using the new iterators.

Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
parent 3a58ee10

include/drm/drm_crtc.h

+5 −1
Original line number Diff line number Diff line
@@ -1606,6 +1606,10 @@ assert_drm_connector_list_read_locked(struct drm_mode_config *mode_config) 
	list_for_each_entry(encoder, &(dev)->mode_config.encoder_list, head)



#define drm_for_each_fb(fb, dev) \

	list_for_each_entry(fb, &(dev)->mode_config.fb_list, head)

	for (WARN_ON(!mutex_is_locked(&(dev)->mode_config.fb_lock)),		\

	     fb = list_first_entry(&(dev)->mode_config.fb_list,	\

					  struct drm_framebuffer, head);	\

	     &fb->head != (&(dev)->mode_config.fb_list);			\

	     fb = list_next_entry(fb, head))



#endif /* __DRM_CRTC_H__ */