Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 463f620b authored by Michał Potomski's avatar Michał Potomski Committed by Martin K. Petersen
Browse files

scsi: ufs: Clean up some rpm/spm level SysFS nodes upon remove 



When reloading module these two attributes aren't cleaned up properly
and they persist causing warnings when trying to load module
again. Additionally they are not recreated properly due to that.

Signed-off-by: default avatarMichał Potomski <michalx.potomski@intel.com>
Reviewed-by: default avatarSubhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent eeeb51d8

drivers/scsi/ufs/ufshcd.c

+7 −0
Original line number Diff line number Diff line
@@ -7698,6 +7698,12 @@ static inline void ufshcd_add_sysfs_nodes(struct ufs_hba *hba) 
	ufshcd_add_spm_lvl_sysfs_nodes(hba);

}



static inline void ufshcd_remove_sysfs_nodes(struct ufs_hba *hba)

{

	device_remove_file(hba->dev, &hba->rpm_lvl_attr);

	device_remove_file(hba->dev, &hba->spm_lvl_attr);

}



/**

 * ufshcd_shutdown - shutdown routine

 * @hba: per adapter instance
@@ -7735,6 +7741,7 @@ EXPORT_SYMBOL(ufshcd_shutdown); 
 */

void ufshcd_remove(struct ufs_hba *hba)

{

	ufshcd_remove_sysfs_nodes(hba);

	scsi_remove_host(hba->host);

	/* disable interrupts */

	ufshcd_disable_intr(hba, hba->intr_mask);