Commit 45fd4470 authored Dec 07, 2017 by Jean Delvare Committed by Wolfram Sang Dec 12, 2017

i2c: piix4: Fix port number check on release



The port number shift is still hard-coded to 1 while it now depends
on the hardware.

Thankfully 0 is always 0 no matter how you shift it, so this was a
bug without consequences.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 0fe16195 ("i2c: piix4: Fix SMBus port selection for AMD Family 17h chips")
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent 9c41e452

drivers/i2c/busses/i2c-piix4.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -983,7 +983,7 @@ static void piix4_adap_remove(struct i2c_adapter *adap)

		if (adapdata->smba) {
		i2c_del_adapter(adap);
		if (adapdata->port == (0 << 1)) {
		if (adapdata->port == (0 << piix4_port_shift_sb800)) {
		release_region(adapdata->smba, SMBIOSIZE);
		if (adapdata->sb800_main)
		release_region(SB800_PIIX4_SMB_IDX, 2);