Commit 452bc149 authored Jan 14, 2015 by Geert Uytterhoeven Committed by Bryan Wu Jan 14, 2015

leds: leds-mc13783: Use of_get_child_by_name() instead of refcount hack



of_find_node_by_name() calls of_node_put() on its "from" parameter.
To counter this, mc13xxx_led_probe_dt() calls of_node_get() first.

Use of_get_child_by_name() instead to get rid of the refcount hack.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Bryan Wu <cooloney@gmail.com>

parent 137fe48d

drivers/leds/leds-mc13783.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -134,9 +134,7 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
		if (!pdata)
		return ERR_PTR(-ENOMEM);

		of_node_get(dev->parent->of_node);

		parent = of_find_node_by_name(dev->parent->of_node, "leds");
		parent = of_get_child_by_name(dev->parent->of_node, "leds");
		if (!parent)
		goto out_node_put;