Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44ed33e6 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Martin K. Petersen
Browse files

scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test 



Remove variable assignments. The value stored in local variable _rc_ is
overwritten at line 2448:rc = lpfc_sli4_bsg_set_link_diag_state(phba,
0); before it can be used.

Addresses-Coverity-ID: 1226935
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarJames Smart <james.smart@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6a8dadcc

drivers/scsi/lpfc/lpfc_bsg.c

+3 −6
Original line number Diff line number Diff line
@@ -2384,20 +2384,17 @@ lpfc_sli4_bsg_link_diag_test(struct bsg_job *job) 
		goto job_error;



	pmboxq = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);

	if (!pmboxq) {

		rc = -ENOMEM;

	if (!pmboxq)

		goto link_diag_test_exit;

	}



	req_len = (sizeof(struct lpfc_mbx_set_link_diag_state) -

		   sizeof(struct lpfc_sli4_cfg_mhdr));

	alloc_len = lpfc_sli4_config(phba, pmboxq, LPFC_MBOX_SUBSYSTEM_FCOE,

				     LPFC_MBOX_OPCODE_FCOE_LINK_DIAG_STATE,

				     req_len, LPFC_SLI4_MBX_EMBED);

	if (alloc_len != req_len) {

		rc = -ENOMEM;

	if (alloc_len != req_len)

		goto link_diag_test_exit;

	}



	run_link_diag_test = &pmboxq->u.mqe.un.link_diag_test;

	bf_set(lpfc_mbx_run_diag_test_link_num, &run_link_diag_test->u.req,

	       phba->sli4_hba.lnk_info.lnk_no);