Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44b815c6 authored by Amitkumar Karwar's avatar Amitkumar Karwar Committed by John W. Linville
Browse files

mwifiex: handle an error path correctly 



In failure case locks are not allocated in mwifiex_register().
So mwifiex_free_lock_list() routine call becomes redundant.
Also we don't need to check return type for mwifiex_init_lock_list()
routine. It never fails.

Signed-off-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent d85c5fe4

drivers/net/wireless/mwifiex/main.c

+1 −4
Original line number Diff line number Diff line
@@ -75,8 +75,7 @@ static int mwifiex_register(void *card, struct mwifiex_if_ops *if_ops, 
	adapter->priv_num++;



	adapter->priv[0]->adapter = adapter;

	if (mwifiex_init_lock_list(adapter))

		goto error;

	mwifiex_init_lock_list(adapter);



	init_timer(&adapter->cmd_timer);

	adapter->cmd_timer.function = mwifiex_cmd_timeout_func;
@@ -87,8 +86,6 @@ static int mwifiex_register(void *card, struct mwifiex_if_ops *if_ops, 
error:

	dev_dbg(adapter->dev, "info: leave mwifiex_register with error\n");



	mwifiex_free_lock_list(adapter);



	for (i = 0; i < adapter->priv_num; i++)

		kfree(adapter->priv[i]);