Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44746438 authored by Jiri Kosina's avatar Jiri Kosina Committed by James Bottomley
Browse files

[SCSI] Buslogic: local_irq_disable() is redundant after local_irq_save() 



drivers/scsi/BusLogic.c::BusLogic_Command() contains local_irq_disable() call
after local_irq_save().  This looks redundant.

Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 083d1631

drivers/scsi/BusLogic.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -362,10 +362,8 @@ static int BusLogic_Command(struct BusLogic_HostAdapter *HostAdapter, enum BusLo 
	   interrupt could occur if the IRQ Channel was previously enabled by another

	   interrupt could occur if the IRQ Channel was previously enabled by another

	   BusLogic Host Adapter or another driver sharing the same IRQ Channel.

	   BusLogic Host Adapter or another driver sharing the same IRQ Channel.

	 */

	 */

	if (!HostAdapter->IRQ_ChannelAcquired) {

	if (!HostAdapter->IRQ_ChannelAcquired)

		local_irq_save(ProcessorFlags);

		local_irq_save(ProcessorFlags);

		local_irq_disable();

	}

	/*

	/*

	   Wait for the Host Adapter Ready bit to be set and the Command/Parameter

	   Wait for the Host Adapter Ready bit to be set and the Command/Parameter

	   Register Busy bit to be reset in the Status Register.

	   Register Busy bit to be reset in the Status Register.