Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 446dfdc6 authored by Mike Isely's avatar Mike Isely Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (11162): pvrusb2: Tie up loose ends with v4l2-subdev setup 



Tie up loose ends with v4l2-subdev setup.  Set attached module's group
ID to match our internal ID, emit a few useful messages when
sub-devices are dealt with, implement better error legs, and fix an
error in the old i2c layer (caused by changes related to the
v4l2-subdev work here).

Signed-off-by: default avatarMike Isely <isely@pobox.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 15b47442

drivers/media/video/pvrusb2/pvrusb2-hdw.c

+14 −5
Original line number Diff line number Diff line
@@ -2020,17 +2020,26 @@ static void pvr2_hdw_load_subdev(struct pvr2_hdw *hdw, 
						i2caddr);

	}



	if (!sd) {

		pvr2_trace(PVR2_TRACE_ERROR_LEGS,

			   "Module ID %u for device %s failed to load"

			   " (this is probably a bad thing...)",

			   mid, hdw->hdw_desc->description);

		return;

	}



	/* Tag this sub-device instance with the module ID we know about.

	   In other places we'll use that tag to determine if the instance

	   requires special handling. */

	sd->grp_id = mid;



	/* If we have both old and new i2c layers enabled, make sure that

	   old layer isn't also tracking this module.  This is a debugging

	   aid, in normal situations there's no reason for both mechanisms

	   to be enabled. */

	pvr2_i2c_untrack_subdev(hdw, sd);

	pvr2_trace(PVR2_TRACE_INIT, "Attached sub-driver %s", fname);



	// ?????

	/* Based on module ID, we should remember subdev pointers

	   so that we can send certain custom commands where

	   needed. */

	// ?????



}