Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4436156b authored by Xin Long's avatar Xin Long Committed by David S. Miller
Browse files

bridge: simplify the stp_state_store by calling store_bridge_parm 



There are some repetitive codes in stp_state_store, we can remove
them by calling store_bridge_parm.

Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Reviewed-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 347db6b4

net/bridge/br_sysfs_br.c

+9 −15
Original line number Diff line number Diff line
@@ -128,27 +128,21 @@ static ssize_t stp_state_show(struct device *d, 
}





static ssize_t stp_state_store(struct device *d,

			       struct device_attribute *attr, const char *buf,

			       size_t len)

static int set_stp_state(struct net_bridge *br, unsigned long val)

{

	struct net_bridge *br = to_bridge(d);

	char *endp;

	unsigned long val;



	if (!ns_capable(dev_net(br->dev)->user_ns, CAP_NET_ADMIN))

		return -EPERM;



	val = simple_strtoul(buf, &endp, 0);

	if (endp == buf)

		return -EINVAL;



	if (!rtnl_trylock())

		return restart_syscall();

	br_stp_set_enabled(br, val);

	rtnl_unlock();



	return len;

	return 0;

}



static ssize_t stp_state_store(struct device *d,

			       struct device_attribute *attr, const char *buf,

			       size_t len)

{

	return store_bridge_parm(d, buf, len, set_stp_state);

}

static DEVICE_ATTR_RW(stp_state);