Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 442d713b authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

ipv6: fix incorrect bitwise operator used on rt6i_flags 



The use of the | operator always leads to true which looks rather
suspect to me. Fix this by using & instead to just check the
RTF_CACHE entry bit.

Detected by CoverityScan, CID#1457734, #1457747 ("Wrong operator used")

Fixes: 35732d01 ("ipv6: introduce a hash table to store dst cache")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarWei Wang <weiwan@google.com>
Acked-by: default avatarMartin KaFai Lau <kafai@fb.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b2427e67

net/ipv6/route.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -1415,7 +1415,7 @@ int rt6_remove_exception_rt(struct rt6_info *rt) 
	int err;

	int err;





	if (!from ||

	if (!from ||

	    !(rt->rt6i_flags | RTF_CACHE))

	    !(rt->rt6i_flags & RTF_CACHE))

		return -EINVAL;

		return -EINVAL;





	if (!rcu_access_pointer(from->rt6i_exception_bucket))

	if (!rcu_access_pointer(from->rt6i_exception_bucket))
@@ -1459,7 +1459,7 @@ static void rt6_update_exception_stamp_rt(struct rt6_info *rt) 
	struct rt6_exception *rt6_ex;

	struct rt6_exception *rt6_ex;





	if (!from ||

	if (!from ||

	    !(rt->rt6i_flags | RTF_CACHE))

	    !(rt->rt6i_flags & RTF_CACHE))

		return;

		return;





	rcu_read_lock();

	rcu_read_lock();