Commit 43052741 authored Jun 27, 2018 by Roman Mashak Committed by David S. Miller Jun 28, 2018

net sched actions: avoid bitwise operation on signed value in pedit



Since char can be unsigned or signed, and bitwise operators may have
implementation-dependent results when performed on signed operands,
declare 'u8 *' operand instead.

Suggested-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 95b0d2dc

net/sched/act_pedit.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -311,7 +311,7 @@ static int tcf_pedit(struct sk_buff skb, const struct tc_action a,
		}

		if (tkey->offmask) {
		char *d, _d;
		u8 *d, _d;

		if (!offset_valid(skb, hoffset + tkey->at)) {
		pr_info("tc action pedit 'at' offset %d out of bounds\n",