Commit 42d284b9 authored Mar 29, 2010 by Julia Lawall Committed by Dominik Brodowski Apr 17, 2010

drivers/pcmcia: Add missing local_irq_restore

Use local_irq_restore in this error-handling case just like in the one just
below.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@r exists@
expression E1;
identifier f;
@@

f (...) { <+...
* local_irq_save (E1,...);
... when != E1
* return ...;
...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>

parent 6f4567c8

drivers/pcmcia/db1xxx_ss.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -166,8 +166,10 @@ static int db1x_pcmcia_setup_irqs(struct db1x_pcmcia_sock *sock)

		ret = request_irq(sock->insert_irq, db1200_pcmcia_cdirq,
		IRQF_DISABLED, "pcmcia_insert", sock);
		if (ret)
		if (ret) {
		local_irq_restore(flags);
		goto out1;
		}

		ret = request_irq(sock->eject_irq, db1200_pcmcia_cdirq,
		IRQF_DISABLED, "pcmcia_eject", sock);