Commit 42838bb2 authored Jan 06, 2011 by Jesper Juhl Committed by Chris Mason Jan 16, 2011

btrfs: Mem leak in btrfs_get_acl()



It seems to me that we leak the memory allocated to 'value' in
btrfs_get_acl() if the call to posix_acl_from_xattr() fails.
Here's a patch that attempts to correct that problem.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Chris Mason <chris.mason@oracle.com>

parent 6d07bcec

fs/btrfs/acl.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -60,8 +60,10 @@ static struct posix_acl btrfs_get_acl(struct inode inode, int type)
		size = __btrfs_getxattr(inode, name, value, size);
		if (size > 0) {
		acl = posix_acl_from_xattr(value, size);
		if (IS_ERR(acl))
		if (IS_ERR(acl)) {
		kfree(value);
		return acl;
		}
		set_cached_acl(inode, type, acl);
		}
		kfree(value);