Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41d0bbc7 authored by Robin Murphy's avatar Robin Murphy Committed by Christoph Hellwig
Browse files

dma-coherent: clarify dma_mmap_from_dev_coherent documentation 



The use of "correctly mapped" here is misleading, since it can give the
wrong expectation in the case that the memory *should* have been mapped
from the per-device pool, but doing so failed for other reasons.

Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 504a918e

drivers/base/dma-coherent.c

+3 −2
Original line number Diff line number Diff line
@@ -312,8 +312,9 @@ static int __dma_mmap_from_coherent(struct dma_coherent_mem *mem, 
 * This checks whether the memory was allocated from the per-device

 * coherent memory pool and if so, maps that memory to the provided vma.

 *

 * Returns 1 if we correctly mapped the memory, or 0 if the caller should

 * proceed with mapping memory from generic pools.

 * Returns 1 if @vaddr belongs to the device coherent pool and the caller

 * should return @ret, or 0 if they should proceed with mapping memory from

 * generic areas.

 */

int dma_mmap_from_dev_coherent(struct device *dev, struct vm_area_struct *vma,

			   void *vaddr, size_t size, int *ret)