Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41c4e350 authored by Shinya Kuribayashi's avatar Shinya Kuribayashi Committed by Ben Dooks
Browse files

i2c-designware: i2c_dw_read: Remove redundant target address checker 



I2c_dw_xfer_msg() also has the same target address inconsistency check,
and furthermore it checks across all i2c_msg messages, while
i2c_dw_read() walks through i2c_msg messages only with_ I2C_M_RD flag.
That is, target address check in i2c_dw_read() is redundant and useless.

Signed-off-by: default avatarShinya Kuribayashi <shinya.kuribayashi@necel.com>
Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
parent 52d7e430

drivers/i2c/busses/i2c-designware.c

+0 −5
Original line number Diff line number Diff line
@@ -419,7 +419,6 @@ static void 
i2c_dw_read(struct dw_i2c_dev *dev)

{

	struct i2c_msg *msgs = dev->msgs;

	u32 addr = msgs[dev->msg_read_idx].addr;

	int rx_valid;



	for (; dev->msg_read_idx < dev->msgs_num; dev->msg_read_idx++) {
@@ -429,10 +428,6 @@ i2c_dw_read(struct dw_i2c_dev *dev) 
		if (!(msgs[dev->msg_read_idx].flags & I2C_M_RD))

			continue;



		/* different i2c client, reprogram the i2c adapter */

		if (msgs[dev->msg_read_idx].addr != addr)

			return;



		if (!(dev->status & STATUS_READ_IN_PROGRESS)) {

			len = msgs[dev->msg_read_idx].len;

			buf = msgs[dev->msg_read_idx].buf;