Commit 41be6a0d authored Jul 10, 2015 by Manfred Schlaegl Committed by Jonathan Cameron Jul 19, 2015

iio: mcp320x: Fix NULL pointer dereference



On reading in_voltage_scale of we got an NULL pointer dereference Oops.

The reason for this is, that mcp320x_read_raw tries to access
chip_info->resolution from struct mcp320x, but chip_info is never set.

chip_info was never set since the driver was added, but there was no
acute problem, because it was not referenced.
The acute problem exists since
b12206e9
iio: adc: mcp320x. Add support for more ADCs

This patch fixes the issue by setting chip_info in mcp320x_probe.

Signed-off-by: Manfred Schlaegl <manfred.schlaegl@gmx.at>
Reviewed-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent bf604a4c

drivers/iio/adc/mcp320x.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -299,6 +299,8 @@ static int mcp320x_probe(struct spi_device *spi)
		indio_dev->channels = chip_info->channels;
		indio_dev->num_channels = chip_info->num_channels;

		adc->chip_info = chip_info;

		adc->transfer[0].tx_buf = &adc->tx_buf;
		adc->transfer[0].len = sizeof(adc->tx_buf);
		adc->transfer[1].rx_buf = adc->rx_buf;