Commit 40f80580 authored Dec 21, 2015 by Linus Walleij

gpio: pcf857x: Be sure to clamp return value



As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Also start returning the error code if something fails, as the
end of the series augment the core to support this.

Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: George Cherian <george.cherian@ti.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent db30aaef

drivers/gpio/gpio-pcf857x.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -154,7 +154,7 @@ static int pcf857x_get(struct gpio_chip *chip, unsigned offset)
		int value;

		value = gpio->read(gpio->client);
		return (value < 0) ? 0 : (value & (1 << offset));
		return (value < 0) ? value : !!(value & (1 << offset));
		}

		static int pcf857x_output(struct gpio_chip *chip, unsigned offset, int value)