Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3fda2432 authored Jul 09, 2018 by Kamal Heib Committed by Jason Gunthorpe Jul 09, 2018

RDMA/ipoib: Fix return code from ipoib_cm_dev_init



The proper return code is -EOPNOTSUPP and not -ENOSYS when the function
isn't supported, also make sure to return the right error code
from ipoib_transport_dev_init() when ipoib_cm_dev_init() is supported.

Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 07e7056a

drivers/infiniband/ulp/ipoib/ipoib.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -729,7 +729,7 @@ void ipoib_cm_dev_stop(struct net_device *dev)
		static inline
		int ipoib_cm_dev_init(struct net_device *dev)
		{
		return -ENOSYS;
		return -EOPNOTSUPP;
		}

		static inline

drivers/infiniband/ulp/ipoib/ipoib_verbs.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -168,8 +168,8 @@ int ipoib_transport_dev_init(struct net_device dev, struct ib_device ca)
		else
		size += ipoib_recvq_size * ipoib_max_conn_qp;
		} else
		if (ret != -ENOSYS)
		return -ENODEV;
		if (ret != -EOPNOTSUPP)
		return ret;

		req_vec = (priv->port - 1) * 2;