Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f550096 authored by Mathieu Desnoyers's avatar Mathieu Desnoyers Committed by Sam Ravnborg
Browse files

Add HAVE_KPROBES



Linus:

On the per-architecture side, I do think it would be better to *not* have
internal architecture knowledge in a generic file, and as such a line like

        depends on X86_32 || IA64 || PPC || S390 || SPARC64 || X86_64 || AVR32

really shouldn't exist in a file like kernel/Kconfig.instrumentation.

It would be much better to do

        depends on ARCH_SUPPORTS_KPROBES

in that generic file, and then architectures that do support it would just
have a

        bool ARCH_SUPPORTS_KPROBES
                default y

in *their* architecture files. That would seem to be much more logical,
and is readable both for arch maintainers *and* for people who have no
clue - and don't care - about which architecture is supposed to support
which interface...

Changelog:

Actually, I know I gave this as the magic incantation, but now that I see
it, I realize that I should have told you to just use

        config KPROBES_SUPPORT
                def_bool y

instead, which is a bit denser.

We seem to use both kinds of syntax for these things, but this is really
what "def_bool" is there for...

- Use HAVE_KPROBES
- Use a select

- Yet another update :
Moving to HAVE_* now.

- Update ARM for kprobes support.

Signed-off-by: default avatarMathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
parent 42d4b839
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ config ARM
	select RTC_LIB
	select SYS_SUPPORTS_APM_EMULATION
	select HAVE_OPROFILE
	select HAVE_KPROBES if (!XIP_KERNEL)
	help
	  The ARM series is a line of low-power-consumption RISC chip designs
	  licensed by ARM Ltd and targeted at embedded applications and
+1 −0
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ config AVR32
	# that we usually don't need on AVR32.
	select EMBEDDED
	select HAVE_OPROFILE
	select HAVE_KPROBES
	help
	  AVR32 is a high-performance 32-bit RISC microprocessor core,
	  designed for cost-sensitive embedded applications, with particular
+1 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ config IA64
	select PM if (!IA64_HP_SIM)
	select ARCH_SUPPORTS_MSI
	select HAVE_OPROFILE
	select HAVE_KPROBES
	default y
	help
	  The Itanium Processor Family is Intel's 64-bit successor to
+1 −0
Original line number Diff line number Diff line
@@ -88,6 +88,7 @@ config PPC
	bool
	default y
	select HAVE_OPROFILE
	select HAVE_KPROBES

config EARLY_PRINTK
	bool
+1 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ config PPC
	bool
	default y
	select HAVE_OPROFILE
	select HAVE_KPROBES

config PPC32
	bool
Loading