Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f463061 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Vinod Koul
Browse files

dmaengine: rcar-dmac: Work around descriptor mode IOMMU errata 



When descriptor memory is accessed through an IOMMU the DMADAR register
isn't initialized automatically from the first descriptor at beginning
of transfer by the DMAC like it should. Initialize it manually with the
destination address of the first chunk.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 6a634808

drivers/dma/sh/rcar-dmac.c

+14 −0
Original line number Diff line number Diff line
@@ -325,6 +325,8 @@ static void rcar_dmac_chan_start_xfer(struct rcar_dmac_chan *chan) 
		rcar_dmac_chan_write(chan, RCAR_DMARS, chan->mid_rid);



	if (desc->hwdescs.use) {

		struct rcar_dmac_xfer_chunk *chunk;



		dev_dbg(chan->chan.device->dev,

			"chan%u: queue desc %p: %u@%pad\n",

			chan->index, desc, desc->nchunks, &desc->hwdescs.dma);
@@ -340,6 +342,18 @@ static void rcar_dmac_chan_start_xfer(struct rcar_dmac_chan *chan) 
				     RCAR_DMACHCRB_DCNT(desc->nchunks - 1) |

				     RCAR_DMACHCRB_DRST);



		/*

		 * Errata: When descriptor memory is accessed through an IOMMU

		 * the DMADAR register isn't initialized automatically from the

		 * first descriptor at beginning of transfer by the DMAC like it

		 * should. Initialize it manually with the destination address

		 * of the first chunk.

		 */

		chunk = list_first_entry(&desc->chunks,

					 struct rcar_dmac_xfer_chunk, node);

		rcar_dmac_chan_write(chan, RCAR_DMADAR,

				     chunk->dst_addr & 0xffffffff);



		/*

		 * Program the descriptor stage interrupt to occur after the end

		 * of the first stage.