Commit 3f2412dc authored Oct 16, 2009 by Mikulas Patocka Committed by Alasdair G Kergon Oct 16, 2009

dm snapshot: require non zero chunk size by end of ctr



If we are creating snapshot with memory-stored exception store, fail if
the user didn't specify chunk size. Zero chunk size would probably crash
a lot of places in the rest of snapshot code.

Cc: stable@kernel.org
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Jonathan Brassow <jbrassow@redhat.com>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

parent f88fb981

drivers/md/dm-snap.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -673,6 +673,11 @@ static int snapshot_ctr(struct dm_target ti, unsigned int argc, char *argv)
		bio_list_init(&s->queued_bios);
		INIT_WORK(&s->queued_bios_work, flush_queued_bios);

		if (!s->store->chunk_size) {
		ti->error = "Chunk size not set";
		goto bad_load_and_register;
		}

		/* Add snapshot to the list of snapshots for this origin */
		/* Exceptions aren't triggered till snapshot_resume() is called */
		if (register_snapshot(s)) {