Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f0d646b authored by Tony Nguyen's avatar Tony Nguyen Committed by Jeff Kirsher
Browse files

ixgbe: Reduce I2C retry count on X550 devices 



A retry count of 10 is likely to run into problems on X550 devices that
have to detect and reset unresponsive CS4227 devices. So, reduce the I2C
retry count to 3 for X550 and above. This should avoid any possible
regressions in existing devices.

Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 910c9c0f

drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c

+3 −1
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ s32 ixgbe_read_i2c_combined_generic_int(struct ixgbe_hw *hw, u8 addr, 
					u16 reg, u16 *val, bool lock)

{

	u32 swfw_mask = hw->phy.phy_semaphore_mask;

	int max_retry = 10;

	int max_retry = 3;

	int retry = 0;

	u8 csum_byte;

	u8 high_bits;
@@ -1755,6 +1755,8 @@ static s32 ixgbe_read_i2c_byte_generic_int(struct ixgbe_hw *hw, u8 byte_offset, 
	u32 swfw_mask = hw->phy.phy_semaphore_mask;

	bool nack = true;



	if (hw->mac.type >= ixgbe_mac_X550)

		max_retry = 3;

	if (ixgbe_is_sfp_probe(hw, byte_offset, dev_addr))

		max_retry = IXGBE_SFP_DETECT_RETRIES;