Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3eeba4a7 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] saa7134,saa7164: warning: comparison of unsigned fixes 



drivers/media/pci/saa7134/saa7134-core.c:947:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
drivers/media/pci/saa7164/saa7164-core.c:413:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/pci/saa7164/saa7164-core.c:489:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/pci/saa7134/saa7134-video.c:2514:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 2827a440

drivers/media/pci/saa7134/saa7134-core.c

+1 −2
Original line number Diff line number Diff line
@@ -944,8 +944,7 @@ static int __devinit saa7134_initdev(struct pci_dev *pci_dev, 


	/* board config */

	dev->board = pci_id->driver_data;

	if (card[dev->nr] >= 0 &&

	    card[dev->nr] < saa7134_bcount)

	if ((unsigned)card[dev->nr] < saa7134_bcount)

		dev->board = card[dev->nr];

	if (SAA7134_BOARD_UNKNOWN == dev->board)

		must_configure_manually(0);

drivers/media/pci/saa7134/saa7134-video.c

+1 −1
Original line number Diff line number Diff line
@@ -2511,7 +2511,7 @@ int saa7134_video_init1(struct saa7134_dev *dev) 
	/* sanitycheck insmod options */

	if (gbuffers < 2 || gbuffers > VIDEO_MAX_FRAME)

		gbuffers = 2;

	if (gbufsize < 0 || gbufsize > gbufsize_max)

	if (gbufsize > gbufsize_max)

		gbufsize = gbufsize_max;

	gbufsize = (gbufsize + PAGE_SIZE - 1) & PAGE_MASK;

drivers/media/pci/saa7164/saa7164-core.c

+2 −2
Original line number Diff line number Diff line
@@ -410,7 +410,7 @@ static void saa7164_work_enchandler(struct work_struct *w) 
		} else

			rp = (port->last_svc_rp + 1) % 8;



		if ((rp < 0) || (rp > (port->hwcfg.buffercount - 1))) {

		if (rp > (port->hwcfg.buffercount - 1)) {

			printk(KERN_ERR "%s() illegal rp count %d\n", __func__, rp);

			break;

		}
@@ -486,7 +486,7 @@ static void saa7164_work_vbihandler(struct work_struct *w) 
		} else

			rp = (port->last_svc_rp + 1) % 8;



		if ((rp < 0) || (rp > (port->hwcfg.buffercount - 1))) {

		if (rp > (port->hwcfg.buffercount - 1)) {

			printk(KERN_ERR "%s() illegal rp count %d\n", __func__, rp);

			break;

		}