Commit 3e6b1cf7 authored Oct 10, 2017 by Shannon Nelson Committed by Jeff Kirsher Oct 31, 2017

i40e: only redistribute MSI-X vectors when needed

Whether or not there are vectors_left, we only need to redistribute
our vectors if we didn't get as many as we requested. With the current
check, the code will try to redistribute even if we did in fact get all
the vectors we requested - this can happen when we have more CPUs than
we do vectors. This restores an earlier check to be sure we only
redistribute if we didn't get the full count we requested.

Fixes: 4ce20abc (i40e: fix MSI-X vector redistribution if hw limit is reached)
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 254d152a

drivers/net/ethernet/intel/i40e/i40e_main.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -9346,7 +9346,7 @@ static int i40e_init_msix(struct i40e_pf *pf)
		pf->num_lan_qps = 1;
		pf->num_lan_msix = 1;

		} else if (!vectors_left) {
		} else if (v_actual != v_budget) {
		/* If we have limited resources, we will start with no vectors
		* for the special features and then allocate vectors to some
		* of these features based on the policy and at the end disable
		@@ -9355,7 +9355,8 @@ static int i40e_init_msix(struct i40e_pf *pf)
		int vec;

		dev_info(&pf->pdev->dev,
		"MSI-X vector limit reached, attempting to redistribute vectors\n");
		"MSI-X vector limit reached with %d, wanted %d, attempting to redistribute vectors\n",
		v_actual, v_budget);
		/* reserve the misc vector */
		vec = v_actual - 1;