Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e14b50d authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: sb - Fix wrong assertions 



snd_assert() in save_mixer() and restore_mixer() in sb_mixer.c is
just wrong.  The debug code wasn't tested at all, obviously...

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 44e05177

sound/isa/sb/sb_mixer.c

+2 −2
Original line number Diff line number Diff line
@@ -925,7 +925,7 @@ static unsigned char als4000_saved_regs[] = { 
static void save_mixer(struct snd_sb *chip, unsigned char *regs, int num_regs)

{

	unsigned char *val = chip->saved_regs;

	snd_assert(num_regs > ARRAY_SIZE(chip->saved_regs), return);

	snd_assert(num_regs <= ARRAY_SIZE(chip->saved_regs), return);

	for (; num_regs; num_regs--)

		*val++ = snd_sbmixer_read(chip, *regs++);

}
@@ -933,7 +933,7 @@ static void save_mixer(struct snd_sb *chip, unsigned char *regs, int num_regs) 
static void restore_mixer(struct snd_sb *chip, unsigned char *regs, int num_regs)

{

	unsigned char *val = chip->saved_regs;

	snd_assert(num_regs > ARRAY_SIZE(chip->saved_regs), return);

	snd_assert(num_regs <= ARRAY_SIZE(chip->saved_regs), return);

	for (; num_regs; num_regs--)

		snd_sbmixer_write(chip, *regs++, *val++);

}