Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3dbf6a54 authored by Alan Stern's avatar Alan Stern Committed by James Bottomley
Browse files

[SCSI] Fix uninitialized variable error in scsi_io_completion 



This patch (as1191) adds a missing "default" case in
scsi_io_completion(), thereby fixing an "uninitialized variable"
error.  It also adds a missing newline to a log entry.

Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent fa990781

drivers/scsi/scsi_lib.c

+5 −1
Original line number Diff line number Diff line
@@ -1029,6 +1029,10 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes) 
				case 0x09: /* self test in progress */

					action = ACTION_DELAYED_RETRY;

					break;

				default:

					description = "Device not ready";

					action = ACTION_FAIL;

					break;

				}

			} else {

				description = "Device not ready";
@@ -1054,7 +1058,7 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes) 
		/* Give up and fail the remainder of the request */

		if (!(req->cmd_flags & REQ_QUIET)) {

			if (description)

				scmd_printk(KERN_INFO, cmd, "%s",

				scmd_printk(KERN_INFO, cmd, "%s\n",

					    description);

			scsi_print_result(cmd);

			if (driver_byte(result) & DRIVER_SENSE)