Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d8ccf9f authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Herbert Xu
Browse files

crypto: chelsio - Fix potential NULL pointer dereferences 



Add null checks on lookup_tid() return value in order to prevent
null pointer dereferences.

Addresses-Coverity-ID: 1467422 ("Dereference null return value")
Addresses-Coverity-ID: 1467443 ("Dereference null return value")
Addresses-Coverity-ID: 1467445 ("Dereference null return value")
Addresses-Coverity-ID: 1467449 ("Dereference null return value")
Fixes: cc35c88a ("crypto : chtls - CPL handler definition")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 31545df3

drivers/crypto/chelsio/chtls/chtls_cm.c

+16 −0
Original line number Diff line number Diff line
@@ -1537,6 +1537,10 @@ static int chtls_rx_data(struct chtls_dev *cdev, struct sk_buff *skb) 
	struct sock *sk;



	sk = lookup_tid(cdev->tids, hwtid);

	if (unlikely(!sk)) {

		pr_err("can't find conn. for hwtid %u.\n", hwtid);

		return -EINVAL;

	}

	skb_dst_set(skb, NULL);

	process_cpl_msg(chtls_recv_data, sk, skb);

	return 0;
@@ -1585,6 +1589,10 @@ static int chtls_rx_pdu(struct chtls_dev *cdev, struct sk_buff *skb) 
	struct sock *sk;



	sk = lookup_tid(cdev->tids, hwtid);

	if (unlikely(!sk)) {

		pr_err("can't find conn. for hwtid %u.\n", hwtid);

		return -EINVAL;

	}

	skb_dst_set(skb, NULL);

	process_cpl_msg(chtls_recv_pdu, sk, skb);

	return 0;
@@ -1646,6 +1654,10 @@ static int chtls_rx_cmp(struct chtls_dev *cdev, struct sk_buff *skb) 
	struct sock *sk;



	sk = lookup_tid(cdev->tids, hwtid);

	if (unlikely(!sk)) {

		pr_err("can't find conn. for hwtid %u.\n", hwtid);

		return -EINVAL;

	}

	skb_dst_set(skb, NULL);

	process_cpl_msg(chtls_rx_hdr, sk, skb);
@@ -2105,6 +2117,10 @@ static int chtls_wr_ack(struct chtls_dev *cdev, struct sk_buff *skb) 
	struct sock *sk;



	sk = lookup_tid(cdev->tids, hwtid);

	if (unlikely(!sk)) {

		pr_err("can't find conn. for hwtid %u.\n", hwtid);

		return -EINVAL;

	}

	process_cpl_msg(chtls_rx_ack, sk, skb);



	return 0;