Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c53e514 authored by Jan Kara's avatar Jan Kara Committed by Linus Torvalds
Browse files

fsnotify: fix check in inotify fdinfo printing 



A check in inotify_fdinfo() checking whether mark is valid was always
true due to a bug.  Luckily we can never get to invalidated marks since
we hold mark_mutex and invalidated marks get removed from the group list
when they are invalidated under that mutex.

Anyway fix the check to make code more future proof.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7c49b861

fs/notify/fdinfo.c

+2 −1
Original line number Diff line number Diff line
@@ -76,7 +76,8 @@ static void inotify_fdinfo(struct seq_file *m, struct fsnotify_mark *mark) 
	struct inotify_inode_mark *inode_mark;

	struct inode *inode;



	if (!(mark->flags & (FSNOTIFY_MARK_FLAG_ALIVE | FSNOTIFY_MARK_FLAG_INODE)))

	if (!(mark->flags & FSNOTIFY_MARK_FLAG_ALIVE) ||

	    !(mark->flags & FSNOTIFY_MARK_FLAG_INODE))

		return;



	inode_mark = container_of(mark, struct inotify_inode_mark, fsn_mark);