Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c0975a7 authored by Frédéric Dalleau's avatar Frédéric Dalleau Committed by Marcel Holtmann
Browse files

Bluetooth: Fix reason code used for rejecting SCO connections 



A comment in the code states that SCO connection should be rejected
with the proper error value between 0xd-0xf. The code uses
HCI_ERROR_REMOTE_LOW_RESOURCES which is 0x14.

This led to following error:
< HCI Command: Reject Synchronous Co.. (0x01|0x002a) plen 7
        Address: 34:51:C9:EF:02:CA (Apple, Inc.)
        Reason: Remote Device Terminated due to Low Resources (0x14)
> HCI Event: Command Status (0x0f) plen 4
      Reject Synchronous Connection Request (0x01|0x002a) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

Instead make use of HCI_ERROR_REJ_LIMITED_RESOURCES which is 0xd.

Signed-off-by: default avatarFrédéric Dalleau <frederic.dalleau@collabora.co.uk>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 0676cab4

net/bluetooth/hci_request.c

+1 −1
Original line number Diff line number Diff line
@@ -1717,7 +1717,7 @@ void __hci_abort_conn(struct hci_request *req, struct hci_conn *conn, 
			 * function. To be safe hard-code one of the

			 * values that's suitable for SCO.

			 */

			rej.reason = HCI_ERROR_REMOTE_LOW_RESOURCES;

			rej.reason = HCI_ERROR_REJ_LIMITED_RESOURCES;



			hci_req_add(req, HCI_OP_REJECT_SYNC_CONN_REQ,

				    sizeof(rej), &rej);