Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a2f335c authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

gpiolib: Don't shadow error code of gpiochip_lock_as_irq() 



gpiochip_lock_as_irq() may return a few error codes,
do not shadow them by -EINVAL and let caller to decide.

No functional change intended.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent cf2ff877

drivers/gpio/gpiolib.c

+4 −2
Original line number Diff line number Diff line
@@ -1805,16 +1805,18 @@ static const struct irq_domain_ops gpiochip_domain_ops = { 
static int gpiochip_irq_reqres(struct irq_data *d)

{

	struct gpio_chip *chip = irq_data_get_irq_chip_data(d);

	int ret;



	if (!try_module_get(chip->gpiodev->owner))

		return -ENODEV;



	if (gpiochip_lock_as_irq(chip, d->hwirq)) {

	ret = gpiochip_lock_as_irq(chip, d->hwirq);

	if (ret) {

		chip_err(chip,

			"unable to lock HW IRQ %lu for IRQ\n",

			d->hwirq);

		module_put(chip->gpiodev->owner);

		return -EINVAL;

		return ret;

	}

	return 0;

}