Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3956c8ac authored by simran singhal's avatar simran singhal Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192u: Clean up tests if NULL returned on failure 



Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: default avatarsimran singhal <singhalsimran0@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c946c698

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c

+1 −1
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ static void *ieee80211_tkip_init(int key_idx) 
	struct ieee80211_tkip_data *priv;



	priv = kzalloc(sizeof(*priv), GFP_ATOMIC);

	if (priv == NULL)

	if (!priv)

		goto fail;

	priv->key_idx = key_idx;

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c

+1 −1
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ static void *prism2_wep_init(int keyidx) 
	struct prism2_wep_data *priv;



	priv = kzalloc(sizeof(*priv), GFP_ATOMIC);

	if (priv == NULL)

	if (!priv)

		return NULL;

	priv->key_idx = keyidx;

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

+1 −1
Original line number Diff line number Diff line
@@ -3025,7 +3025,7 @@ static int ieee80211_wpa_set_encryption(struct ieee80211_device *ieee, 
		ieee80211_crypt_delayed_deinit(ieee, crypt);



		new_crypt = kzalloc(sizeof(*new_crypt), GFP_KERNEL);

		if (new_crypt == NULL) {

		if (!new_crypt) {

			ret = -ENOMEM;

			goto done;

		}

drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c

+2 −2
Original line number Diff line number Diff line
@@ -362,7 +362,7 @@ int ieee80211_wx_set_encode(struct ieee80211_device *ieee, 
		/* take WEP into use */

		new_crypt = kzalloc(sizeof(struct ieee80211_crypt_data),

				    GFP_KERNEL);

		if (new_crypt == NULL)

		if (!new_crypt)

			return -ENOMEM;

		new_crypt->ops = ieee80211_get_crypto_ops("WEP");

		if (!new_crypt->ops) {
@@ -610,7 +610,7 @@ int ieee80211_wx_set_encode_ext(struct ieee80211_device *ieee, 
		ieee80211_crypt_delayed_deinit(ieee, crypt);



		new_crypt = kzalloc(sizeof(*new_crypt), GFP_KERNEL);

		if (new_crypt == NULL) {

		if (!new_crypt) {

			ret = -ENOMEM;

			goto done;

		}