Commit 3948b6f2 authored Feb 18, 2016 by Tejun Heo

libata: fix unbalanced spin_lock_irqsave/spin_unlock_irq() in ata_scsi_park_show()



ata_scsi_park_show() was pairing spin_lock_irqsave() with
spin_unlock_irq().  As the function is always called with irq enabled,
it didn't actually break anything.  Use spin_lock_irq() instead.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Elias Oltmanns <eo@nebensachen.de>

parent a2127e40

drivers/ata/libata-scsi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -174,13 +174,13 @@ static ssize_t ata_scsi_park_show(struct device *device,
		struct ata_port *ap;
		struct ata_link *link;
		struct ata_device *dev;
		unsigned long flags, now;
		unsigned long now;
		unsigned int uninitialized_var(msecs);
		int rc = 0;

		ap = ata_shost_to_port(sdev->host);

		spin_lock_irqsave(ap->lock, flags);
		spin_lock_irq(ap->lock);
		dev = ata_scsi_find_dev(ap, sdev);
		if (!dev) {
		rc = -ENODEV;