Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3924c623 authored by Hugues Fruchet's avatar Hugues Fruchet Committed by Mauro Carvalho Chehab
Browse files

media: ov5640: add error trace in case of i2c read failure 



Add an error trace in ov5640_read_reg() in case of i2c_transfer()
failure.
Uniformize error traces using dev_err instead v4l2_err.

Signed-off-by: default avatarHugues Fruchet <hugues.fruchet@st.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent d47c4126

drivers/media/i2c/ov5640.c

+5 −2
Original line number Diff line number Diff line
@@ -839,7 +839,7 @@ static int ov5640_write_reg(struct ov5640_dev *sensor, u16 reg, u8 val) 


	ret = i2c_transfer(client->adapter, &msg, 1);

	if (ret < 0) {

		v4l2_err(&sensor->sd, "%s: error: reg=%x, val=%x\n",

		dev_err(&client->dev, "%s: error: reg=%x, val=%x\n",

			__func__, reg, val);

		return ret;

	}
@@ -868,8 +868,11 @@ static int ov5640_read_reg(struct ov5640_dev *sensor, u16 reg, u8 *val) 
	msg[1].len = 1;



	ret = i2c_transfer(client->adapter, msg, 2);

	if (ret < 0)

	if (ret < 0) {

		dev_err(&client->dev, "%s: error: reg=%x\n",

			__func__, reg);

		return ret;

	}



	*val = buf[0];

	return 0;