Commit 372bd282 authored Dec 16, 2008 by Julia Lawall Committed by James Bottomley Jan 02, 2009

[SCSI] lpfc: Move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: James Smart <James.Smart@Emulex.Com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent b99b4c67

drivers/scsi/lpfc/lpfc_init.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1795,12 +1795,13 @@ lpfc_block_mgmt_io(struct lpfc_hba * phba)
		int
		lpfc_online(struct lpfc_hba *phba)
		{
		struct lpfc_vport *vport = phba->pport;
		struct lpfc_vport *vport;
		struct lpfc_vport **vports;
		int i;

		if (!phba)
		return 0;
		vport = phba->pport;

		if (!(vport->fc_flag & FC_OFFLINE_MODE))
		return 0;