Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34015f5e authored by Linus Walleij's avatar Linus Walleij Committed by Mark Brown
Browse files

ASoC: ac97: Be sure to clamp return value 



As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9bf5c3d1

sound/soc/soc-ac97.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -92,7 +92,7 @@ static int snd_soc_ac97_gpio_get(struct gpio_chip *chip, unsigned offset) 
	dev_dbg(codec->dev, "get gpio %d : %d\n", offset,

	dev_dbg(codec->dev, "get gpio %d : %d\n", offset,

		ret < 0 ? ret : ret & (1 << offset));

		ret < 0 ? ret : ret & (1 << offset));





	return ret < 0 ? ret : ret & (1 << offset);

	return ret < 0 ? ret : !!(ret & (1 << offset));

}

}





static void snd_soc_ac97_gpio_set(struct gpio_chip *chip, unsigned offset,

static void snd_soc_ac97_gpio_set(struct gpio_chip *chip, unsigned offset,