Commit 336eac43 authored Nov 06, 2017 by Christophe JAILLET Committed by David S. Miller Nov 08, 2017

fsl/fman: Remove some useless code



There is no need to release explicitly some devm_ allocated resources.
If the 'mac_probe()' probe function fails, they will be released
automatically, as already done in the other error handling paths of
this function.

Also goto '_return_of_get_parent' as in the other error handling paths.
This is useless (priv->fixed_link is NULL at this point), but at least
it is consistent.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5adb55c9

drivers/net/ethernet/freescale/fman/mac.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -709,11 +709,8 @@ static int mac_probe(struct platform_device *_of_dev)
		}

		if (!of_device_is_available(mac_node)) {
		devm_iounmap(dev, priv->vaddr);
		__devm_release_region(dev, fman_get_mem_region(priv->fman),
		res.start, res.end + 1 - res.start);
		devm_kfree(dev, mac_dev);
		return -ENODEV;
		err = -ENODEV;
		goto _return_of_get_parent;
		}

		/* Get the cell-index */