Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 327f242f authored by Xiaofei Tan's avatar Xiaofei Tan Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: check IPTT is valid before using it for v3 hw 



There is a bug of v3 hw development version. When AXI error happen, hw
may return an abnormal CQ that IPTT value is 0xffff.  This will cause
IPTT out-of-bounds reference.

This patch adds a check of IPTT in cq_tasklet_v3_hw() and discards
invalid slot. This workaround scheme is just to enhance fault-tolerance
of the driver. So, we will apply this scheme for all version of v3 hw,
although release version has fixed this SoC bug.

Signed-off-by: default avatarXiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3ff0f0b6

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

+8 −4
Original line number Diff line number Diff line
@@ -1731,15 +1731,19 @@ static void cq_tasklet_v3_hw(unsigned long val) 


	while (rd_point != wr_point) {

		struct hisi_sas_complete_v3_hdr *complete_hdr;

		struct device *dev = hisi_hba->dev;

		int iptt;



		complete_hdr = &complete_queue[rd_point];



		iptt = (complete_hdr->dw1) & CMPLT_HDR_IPTT_MSK;

		if (likely(iptt < HISI_SAS_COMMAND_ENTRIES_V3_HW)) {

			slot = &hisi_hba->slot_info[iptt];

			slot->cmplt_queue_slot = rd_point;

			slot->cmplt_queue = queue;

			slot_complete_v3_hw(hisi_hba, slot);

		} else

			dev_err(dev, "IPTT %d is invalid, discard it.\n", iptt);



		if (++rd_point >= HISI_SAS_QUEUE_SLOTS)

			rd_point = 0;