Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 325f5091 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf trace: Ditch __syscall__arg_val() variant, not needed anymore 

All callers now can use syscall__arg_val(arg, idx), be it to iterate
thru the syscall arguments while taking into account alignment, or to
get values for other arguments that affect how the current argument
should be formatted (think of fcntl's 'cmd' and 'arg' arguments).

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-wm5b156d8kro1r4y3b33eyta@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent d032d79e

tools/perf/builtin-trace.c

+2 −7
Original line number Diff line number Diff line
@@ -1336,20 +1336,15 @@ static int trace__validate_ev_qualifier(struct trace *trace) 
 * variable to read it. Most notably this avoids extended load instructions

 * on unaligned addresses

 */

static unsigned long __syscall_arg__val(unsigned char *args, u8 idx)

unsigned long syscall_arg__val(struct syscall_arg *arg, u8 idx)

{

	unsigned long val;

	unsigned char *p = args + sizeof(unsigned long) * idx;

	unsigned char *p = arg->args + sizeof(unsigned long) * idx;



	memcpy(&val, p, sizeof(val));

	return val;

}



unsigned long syscall_arg__val(struct syscall_arg *arg, u8 idx)

{

	return __syscall_arg__val(arg->args, idx);

}



static size_t syscall__scnprintf_val(struct syscall *sc, char *bf, size_t size,

				     struct syscall_arg *arg, unsigned long val)

{