Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3245c206 authored by Bart Van Assche's avatar Bart Van Assche Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: Fix session lookup in qlt_abort_work() 



[ Upstream commit ac452b8e79320c9e90c78edf32ba2d42431e4daf ]

Pass the correct session ID to find_sess_by_s_id() instead of passing an
uninitialized variable.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Fixes: 2d70c103 ("[SCSI] qla2xxx: Add LLD target-mode infrastructure for >= 24xx series") # v3.5.
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Tested-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Reviewed-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e46f7e2f

drivers/scsi/qla2xxx/qla_target.c

+1 −3
Original line number Diff line number Diff line
@@ -6062,7 +6062,6 @@ static void qlt_abort_work(struct qla_tgt *tgt, 
	struct qla_hw_data *ha = vha->hw;

	struct fc_port *sess = NULL;

	unsigned long flags = 0, flags2 = 0;

	uint32_t be_s_id;

	uint8_t s_id[3];

	int rc;
@@ -6075,8 +6074,7 @@ static void qlt_abort_work(struct qla_tgt *tgt, 
	s_id[1] = prm->abts.fcp_hdr_le.s_id[1];

	s_id[2] = prm->abts.fcp_hdr_le.s_id[0];



	sess = ha->tgt.tgt_ops->find_sess_by_s_id(vha,

	    (unsigned char *)&be_s_id);

	sess = ha->tgt.tgt_ops->find_sess_by_s_id(vha, s_id);

	if (!sess) {

		spin_unlock_irqrestore(&ha->tgt.sess_lock, flags2);