Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31a86d13 authored by Eran Ben Elisha's avatar Eran Ben Elisha Committed by David S. Miller
Browse files

net: ethtool: Initialize buffer when querying device channel settings 



Ethtool channels respond struct was uninitialized when querying device
channel boundaries settings. As a result, unreported fields by the driver
hold garbage.  This may cause sending unsupported params to driver.

Fixes: 8bf36862 ('ethtool: ensure channel counts are within bounds ...')
Signed-off-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
CC: John W. Linville <linville@tuxdriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 003ecadd

net/core/ethtool.c

+1 −1
Original line number Diff line number Diff line
@@ -1712,7 +1712,7 @@ static noinline_for_stack int ethtool_get_channels(struct net_device *dev, 
static noinline_for_stack int ethtool_set_channels(struct net_device *dev,

						   void __user *useraddr)

{

	struct ethtool_channels channels, max;

	struct ethtool_channels channels, max = { .cmd = ETHTOOL_GCHANNELS };

	u32 max_rx_in_use = 0;



	if (!dev->ethtool_ops->set_channels || !dev->ethtool_ops->get_channels)