Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30c07022 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: seq: fix passing wrong pointer in function call of compatibility layer 



This commit is a fix for Linux 4.9-rc1.

In former commit, a function call of compatibility layer for ALSA sequencer
core was obsoleted by an alternative. Although, the alternative gets a
pointer to kernel stack due to mis-programming. As a result, ALSA sequencer
core unexpectedly refers over kernel stack.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: 8ce8eb60 ("ALSA: seq: add an alternative way to handle ioctl requests")
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 4875a5f7

sound/core/seq/seq_compat.c

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ static int snd_seq_call_port_info_ioctl(struct snd_seq_client *client, unsigned 
		goto error;

	data->kernel = NULL;



	err = snd_seq_kernel_client_ctl(client->number, cmd, &data);

	err = snd_seq_kernel_client_ctl(client->number, cmd, data);

	if (err < 0)

		goto error;