Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30a7eb29 authored by Adrian Hunter's avatar Adrian Hunter Committed by David Woodhouse
Browse files

[MTD] [OneNAND] Return only negative error codes 



The OneNAND driver was confusing JFFS2 by returning positive error
codes.

Signed-off-by: default avatarAdrian Hunter <ext-adrian.hunter@nokia.com>
Acked-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
parent 34627f0e

drivers/mtd/onenand/onenand_base.c

+2 −2
Original line number Diff line number Diff line
@@ -327,7 +327,7 @@ static int onenand_wait(struct mtd_info *mtd, int state) 
		printk(KERN_ERR "onenand_wait: controller error = 0x%04x\n", ctrl);

		if (ctrl & ONENAND_CTRL_LOCK)

			printk(KERN_ERR "onenand_wait: it's locked error.\n");

		return ctrl;

		return -EIO;

	}



	if (interrupt & ONENAND_INT_READ) {
@@ -336,7 +336,7 @@ static int onenand_wait(struct mtd_info *mtd, int state) 
			if (ecc & ONENAND_ECC_2BIT_ALL) {

				printk(KERN_ERR "onenand_wait: ECC error = 0x%04x\n", ecc);

				mtd->ecc_stats.failed++;

				return ecc;

				return -EBADMSG;

			} else if (ecc & ONENAND_ECC_1BIT_ALL) {

				printk(KERN_INFO "onenand_wait: correctable ECC error = 0x%04x\n", ecc);

				mtd->ecc_stats.corrected++;