Commit 30a366a9 authored Dec 20, 2017 by Bryan Tan Committed by Jason Gunthorpe Dec 21, 2017

RDMA/vmw_pvrdma: Use refcount_dec_and_test to avoid warning



refcount_dec generates a warning when the operation
causes the refcount to hit zero. Avoid this by using
refcount_dec_and_test.

Fixes: 8b10ba78 ("RDMA/vmw_pvrdma: Add shared receive queue support")
Reviewed-by: Adit Ranadive <aditr@vmware.com>
Reviewed-by: Aditya Sarwade <asarwade@vmware.com>
Reviewed-by: Jorgen Hansen <jhansen@vmware.com>
Signed-off-by: Bryan Tan <bryantan@vmware.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 17748056

drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -236,7 +236,7 @@ static void pvrdma_free_srq(struct pvrdma_dev dev, struct pvrdma_srq srq)
		dev->srq_tbl[srq->srq_handle] = NULL;
		spin_unlock_irqrestore(&dev->srq_tbl_lock, flags);

		refcount_dec(&srq->refcnt);
		if (!refcount_dec_and_test(&srq->refcnt))
		wait_event(srq->wait, !refcount_read(&srq->refcnt));

		/* There is no support for kernel clients, so this is safe. */