Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f6e5f94 authored by Yong Zhang's avatar Yong Zhang Committed by Linus Torvalds
Browse files

drivers/rtc: remove IRQF_DISABLED 



Since commit e58aa3d2 ("genirq: run irq handlers with interrupts
disabled") we run all interrupt handlers with interrupts disabled and we
even check and yell when an interrupt handler returns with interrupts
enabled - see commit b738a50a ("genirq: warn when handler enables
interrupts").

So now this flag is a NOOP and can be removed.

Signed-off-by: default avatarYong Zhang <yong.zhang0@gmail.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarWan ZongShun <mcuos.com@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2778ebcc

drivers/rtc/rtc-at91sam9.c

+1 −1
Original line number Diff line number Diff line
@@ -335,7 +335,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) 


	/* register irq handler after we know what name we'll use */

	ret = request_irq(AT91_ID_SYS, at91_rtc_interrupt,

				IRQF_DISABLED | IRQF_SHARED,

				IRQF_SHARED,

				dev_name(&rtc->rtcdev->dev), rtc);

	if (ret) {

		dev_dbg(&pdev->dev, "can't share IRQ %d?\n", AT91_ID_SYS);

drivers/rtc/rtc-cmos.c

+1 −1
Original line number Diff line number Diff line
@@ -714,7 +714,7 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq) 
			rtc_cmos_int_handler = cmos_interrupt;



		retval = request_irq(rtc_irq, rtc_cmos_int_handler,

				IRQF_DISABLED, dev_name(&cmos_rtc.rtc->dev),

				0, dev_name(&cmos_rtc.rtc->dev),

				cmos_rtc.rtc);

		if (retval < 0) {

			dev_dbg(dev, "IRQ %d is already in use\n", rtc_irq);

drivers/rtc/rtc-coh901331.c

+1 −1
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ static int __init coh901331_probe(struct platform_device *pdev) 
	}



	rtap->irq = platform_get_irq(pdev, 0);

	if (request_irq(rtap->irq, coh901331_interrupt, IRQF_DISABLED,

	if (request_irq(rtap->irq, coh901331_interrupt, 0,

			"RTC COH 901 331 Alarm", rtap)) {

		ret = -EIO;

		goto out_no_irq;

drivers/rtc/rtc-davinci.c

+1 −1
Original line number Diff line number Diff line
@@ -542,7 +542,7 @@ static int __init davinci_rtc_probe(struct platform_device *pdev) 
	rtcss_write(davinci_rtc, 0, PRTCSS_RTC_CCTRL);



	ret = request_irq(davinci_rtc->irq, davinci_rtc_interrupt,

			  IRQF_DISABLED, "davinci_rtc", davinci_rtc);

			  0, "davinci_rtc", davinci_rtc);

	if (ret < 0) {

		dev_err(dev, "unable to register davinci RTC interrupt\n");

		goto fail4;

drivers/rtc/rtc-ds1511.c

+1 −1
Original line number Diff line number Diff line
@@ -532,7 +532,7 @@ ds1511_rtc_probe(struct platform_device *pdev) 
	if (pdata->irq > 0) {

		rtc_read(RTC_CMD1);

		if (devm_request_irq(&pdev->dev, pdata->irq, ds1511_interrupt,

			IRQF_DISABLED | IRQF_SHARED, pdev->name, pdev) < 0) {

			IRQF_SHARED, pdev->name, pdev) < 0) {



			dev_warn(&pdev->dev, "interrupt not available.\n");

			pdata->irq = 0;