Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f019123 authored by Mitch Williams's avatar Mitch Williams Committed by Jeff Kirsher
Browse files

i40e: reinit buffer size each time 



When cleaning the ARQ, we must reinitialize the buffer size each time we
go through the loop, because i40e_clean_arq_element returns the message
length in the same field. Without this change, subsequent messages can
be truncated to the length of the previous message.

Change-Id: Ic9c32ff843faf0fc3196d21351a1c3a60c6158eb
Signed-off-by: default avatarMitch Williams <mitch.a.williams@intel.com>
Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: default avatarKavindya Deegala <kavindya.s.deegala@intel.com>
Tested-by: default avatarSibai Li <sibai.li@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 2ef28cfb

drivers/net/ethernet/intel/i40e/i40e_main.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -4493,12 +4493,12 @@ static void i40e_clean_adminq_subtask(struct i40e_pf *pf) 
	if (!test_bit(__I40E_ADMINQ_EVENT_PENDING, &pf->state))

	if (!test_bit(__I40E_ADMINQ_EVENT_PENDING, &pf->state))

		return;

		return;





	event.msg_size = I40E_MAX_AQ_BUF_SIZE;

	event.msg_buf = kzalloc(event.msg_size, GFP_KERNEL);

	event.msg_buf = kzalloc(event.msg_size, GFP_KERNEL);

	if (!event.msg_buf)

	if (!event.msg_buf)

		return;

		return;





	do {

	do {

		event.msg_size = I40E_MAX_AQ_BUF_SIZE; /* reinit each time */

		ret = i40e_clean_arq_element(hw, &event, &pending);

		ret = i40e_clean_arq_element(hw, &event, &pending);

		if (ret == I40E_ERR_ADMIN_QUEUE_NO_WORK) {

		if (ret == I40E_ERR_ADMIN_QUEUE_NO_WORK) {

			dev_info(&pf->pdev->dev, "No ARQ event found\n");

			dev_info(&pf->pdev->dev, "No ARQ event found\n");