Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ee3e26c authored by Ben Hutchings's avatar Ben Hutchings Committed by James Bottomley
Browse files

[SCSI] sd: Fix parsing of 'temporary ' cache mode prefix 



Commit 39c60a09 '[SCSI] sd: fix array cache flushing bug causing
performance problems' added temp as a pointer to "temporary " and used
sizeof(temp) - 1 as its length.  But sizeof(temp) is the size of the
pointer, not the size of the string constant.  Change temp to a static
array so that sizeof() does what was intended.

Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent c6e23d83

drivers/scsi/sd.c

+1 −1
Original line number Diff line number Diff line
@@ -142,7 +142,7 @@ sd_store_cache_type(struct device *dev, struct device_attribute *attr, 
	char *buffer_data;

	struct scsi_mode_data data;

	struct scsi_sense_hdr sshdr;

	const char *temp = "temporary ";

	static const char temp[] = "temporary ";

	int len;



	if (sdp->type != TYPE_DISK)