Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e9bf247 authored by Jaroslav Kysela's avatar Jaroslav Kysela Committed by Takashi Iwai
Browse files

ALSA: hda_codec: Check for invalid zero connections 



To prevent "Too many connections" message and the error path for some HDMI
codecs (which makes onboard audio unusable), check for invalid zero
connections for CONNECT_LIST verb.

Signed-off-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9d30937a

sound/pci/hda/hda_codec.c

+6 −0
Original line number Original line Diff line number Diff line
@@ -332,6 +332,12 @@ int snd_hda_get_connections(struct hda_codec *codec, hda_nid_t nid, 
						  AC_VERB_GET_CONNECT_LIST, i);

						  AC_VERB_GET_CONNECT_LIST, i);

		range_val = !!(parm & (1 << (shift-1))); /* ranges */

		range_val = !!(parm & (1 << (shift-1))); /* ranges */

		val = parm & mask;

		val = parm & mask;

		if (val == 0) {

			snd_printk(KERN_WARNING "hda_codec: "

				   "invalid CONNECT_LIST verb %x[%i]:%x\n",

				    nid, i, parm);

			return 0;

		}

		parm >>= shift;

		parm >>= shift;

		if (range_val) {

		if (range_val) {

			/* ranges between the previous and this one */

			/* ranges between the previous and this one */